[Identity] Add VSCodeCredential #7994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaabs
reviewed
Mar 25, 2020
schaabs
reviewed
Mar 25, 2020
| if (scopeString.indexOf("offline_access") < 0) { | ||
| scopeString += " offline_access"; | ||
| } | ||
| let refreshToken = await keytar.findPassword("VS Code Azure"); |
There was a problem hiding this comment.
I wonder if we should try to avoid reading this every time getToken is called. Do you know what the performance of it is?
There was a problem hiding this comment.
VS Code Azure should be a const with a descriptive name
There was a problem hiding this comment.
Performance-wise it's similar to Azure SDK credentials, perhaps a bit faster for the initial connection.
schaabs
approved these changes
Mar 25, 2020
|
@schaabs - sounds good, I'll file an issue for that. |
xirzec
added a commit
to xirzec/azure-sdk-for-js
that referenced
this pull request
Mar 27, 2020
PR Azure#7994 introduced a build break to rollup by referencing `process` inside `DefaultAzureCredential`. This fix adds a browser version of `DefaultAzureCredential` without the reference to `process`.
xirzec
added a commit
that referenced
this pull request
Mar 27, 2020
PR #7994 introduced a build break to rollup by referencing `process` inside `DefaultAzureCredential`. This fix adds a browser version of `DefaultAzureCredential` without the reference to `process`.
xirzec
added a commit
to xirzec/azure-sdk-for-js
that referenced
this pull request
Mar 28, 2020
PR Azure#7994 also introduced a problem where a new dependency `keytar` is not bundle safe and needed to be excluded in test bundles that referenced it indirectly via @azure/identity.
xirzec
added a commit
that referenced
this pull request
Mar 28, 2020
PR #7994 also introduced a problem where a new dependency `keytar` is not bundle safe and needed to be excluded in test bundles that referenced it indirectly via @azure/identity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the VSCodeCredential and adds it to the DefaultAzureCredential.
Drafting for feedback before I finish.
This PR also adds the user-defined managed identity to the DefaultAzureCredential.