Address CreateCall bugs (#34273)

* fix transfer logic * fix createCall issues
Azure · Feb 17, 2023 · ffac496 · ffac496
1 parent 074431d
commit ffac496
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/sdk/communication/Azure.Communication.CallAutomation/src/CallAutomationClient.cs b/sdk/communication/Azure.Communication.CallAutomation/src/CallAutomationClient.cs
@@ -659,7 +659,7 @@ private CreateCallRequestInternal CreateCallRequest(CreateGroupCallOptions optio
                     ? null
                     : new PhoneNumberIdentifierModel(options?.SourceCallerIdNumber?.PhoneNumber),
                 SourceDisplayName = options?.SourceDisplayName,
-                SourceIdentity = CommunicationIdentifierSerializer.Serialize(Source),
+                SourceIdentity = Source == null ? null : CommunicationIdentifierSerializer.Serialize(Source),
             };
             // Add custom cognitive service domain name
             if (options.AzureCognitiveServicesEndpointUrl != null)

diff --git a/sdk/communication/Azure.Communication.CallAutomation/src/Models/CallConnectionProperties.cs b/sdk/communication/Azure.Communication.CallAutomation/src/Models/CallConnectionProperties.cs
@@ -55,11 +55,7 @@ internal CallConnectionProperties(CallConnectionPropertiesInternal callConnectio
 
             if (callConnectionPropertiesDtoInternal.SourceCallerIdNumber != null)
             {
-                var communicationIdentifierModel = new CommunicationIdentifierModel
-                {
-                    PhoneNumber = callConnectionPropertiesDtoInternal.SourceCallerIdNumber,
-                };
-                SourceCallerIdNumber = (PhoneNumberIdentifier)CommunicationIdentifierSerializer.Deserialize(communicationIdentifierModel);
+                SourceCallerIdNumber = new PhoneNumberIdentifier(callConnectionPropertiesDtoInternal.SourceCallerIdNumber.Value);
             }
         }