Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Managed HSM tests to run on a single platform #16531

Closed
heaths opened this issue Nov 3, 2020 · 1 comment
Closed

Enable Managed HSM tests to run on a single platform #16531

heaths opened this issue Nov 3, 2020 · 1 comment
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable
Milestone
[2021] February

Comments

@heaths
Copy link
Member

heaths commented Nov 3, 2020

We can only deploy 1 Managed HSM per subscription per region during its preview. As such, I have to limit how we deploy it for automated testing. I don't want to mark it "Manual" because it will never be tested, so instead I'm using conditional compilation (could use test-discovery attributes, but this is easier for the same effect).

When we can deploy more or if we decide to run all platforms' tests serially (would take a long time), we should take out the code to run the tests on all platforms.
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable labels Nov 3, 2020
@heaths heaths added this to the [2021] February milestone Nov 3, 2020
@heaths heaths self-assigned this Nov 3, 2020
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Nov 3, 2020
@heaths
Run Managed HSM tests manually
8c6d9d2 
Fixes nightly and weekly runs until Azure#16531 is fixed.
@heaths heaths mentioned this issue Nov 3, 2020
Merged
ghost pushed a commit that referenced this issue Nov 4, 2020
@heaths
Only provision and test Managed HSM when opted in (#16554)
2888d40 
Fixes nightly and weekly runs until #16531 is fixed.
@heaths heaths changed the title Enable Managed HSM tests to run on every platform Enable Managed HSM tests to run on a single platform Nov 6, 2020
@heaths
Copy link
Member Author

heaths commented Nov 6, 2020

Now dup of #16483

@heaths heaths closed this as completed Nov 6, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@heaths @annelo-msft
Only provision and test Managed HSM when opted in (Azure#16554)
d7d2c69 
Fixes nightly and weekly runs until Azure#16531 is fixed.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
[2021] February
Development

No branches or pull requests
1 participant
@heaths