Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebJobs/EventHubs] Migrate initial offset configuration feature #17521

Closed
pakrym opened this issue Dec 15, 2020 · 2 comments · Fixed by #17727
Closed

[WebJobs/EventHubs] Migrate initial offset configuration feature #17521

pakrym opened this issue Dec 15, 2020 · 2 comments · Fixed by #17727
Assignees
@JoshLove-msft
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Extensions ASP.NET Core extensions
Milestone
[2021] January

Comments

@pakrym
Copy link
Contributor

pakrym commented Dec 15, 2020

Azure/azure-functions-eventhubs-extension#79 was merged after our initial migration.
@pakrym pakrym added Event Hubs Client This issue points to a problem in the data-plane of the library. Extensions ASP.NET Core extensions labels Dec 15, 2020
@pakrym pakrym added this to the [2021] January milestone Dec 15, 2020
@JoshLove-msft
Copy link
Member

JoshLove-msft commented Dec 30, 2020 •
edited
Loading

This feature relies on the InitialOffsetProvider option in EventProcessorOptions, which isn't available in Track 2. @jsquire do you know why this wasn't included for Track 2? Any objections to including it now, or is there another hook that we can use? I think this is where we need to update to read the InitialOffset if there are no checkpoints - https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/eventhub/Azure.Messaging.EventHubs/src/Primitives/EventProcessor.cs#L1365

@JoshLove-msft
Copy link
Member

Nevermind, I see that we have the DefaultStartingPosition property in Track 2.

@JoshLove-msft JoshLove-msft mentioned this issue Dec 31, 2020
Merged
@ghost ghost closed this as completed in #17727 Jan 5, 2021
ghost pushed a commit that referenced this issue Jan 5, 2021
@JoshLove-msft
Add option for initial offset (#17727)
2ad2c21 
Fixes #17521
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@JoshLove-msft @annelo-msft
Add option for initial offset (Azure#17727)
9f463b5 
Fixes Azure#17521
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshLove-msft JoshLove-msft

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Extensions ASP.NET Core extensions
Projects
None yet
Milestone
[2021] January
Development

Successfully merging a pull request may close this issue.

Add option for initial offset JoshLove-msft/azure-sdk-for-net
2 participants
@pakrym @JoshLove-msft