Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Azure.Data.Tables Sas builder has EndPartitionKey and StartRowKey parameter values mixed #17535

Closed
ssiltanen opened this issue Dec 15, 2020 · 1 comment · Fixed by #17740
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables

Comments

@ssiltanen
Copy link

Describe the bug
In file sdk/tables/Azure.Data.Tables/src/TableConstants.cs rows 102 and 103 have values mixed

public const string EndPartitionKey = "startrk";
public const string StartRowKey = "endpk";

I suppose EndPartitionKey should be "endpk" and StartRowKey should be startrk. This mix up causes generated sas query parameter to not work if partitionkey start and end values are provided or rowkey start and end.

Expected behavior

// Setting sas builder values
sasbuilder.PartitionKeyStart = "pk1";
sasbuilder.PartitionKeyEnd = "pk2";
sasbuilder.RowKeyStart = "rk1";
sasbuilder.RowKeyEnd = "rk2";
// After signing produces
startpk=pk1&startrk=rk1&endpk=pk2&endrk=rk2

Actual behavior (include Exception or Stack Trace)

// Setting sas builder values
sasbuilder.PartitionKeyStart = "pk1";
sasbuilder.PartitionKeyEnd = "pk2";
sasbuilder.RowKeyStart = "rk1";
sasbuilder.RowKeyEnd = "rk2";
// After signing produces
startpk=pk1&startrk=pk2&endpk=rk1&endrk=rk2

Environment:

  • Name and version of the Library package used: Azure.Data.Tables 3.0.0-beta.4
  • .NET SDK (reflecting any global.json):
    Version: 5.0.100
    Commit: 5044b93829

Runtime Environment:
OS Name: Mac OS X
OS Version: 10.15
OS Platform: Darwin
RID: osx.10.15-x64
Base Path: /usr/local/share/dotnet/sdk/5.0.100/

Host (useful for support):
Version: 5.0.0
Commit: cf258a14b7

.NET SDKs installed:
3.1.301 [/usr/local/share/dotnet/sdk]
5.0.100 [/usr/local/share/dotnet/sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 3.1.5 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.5 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 15, 2020
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Tables labels Dec 15, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 15, 2020
@jsquire
Copy link
Member

jsquire commented Dec 15, 2020

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@christothes christothes removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jan 4, 2021
@ghost ghost closed this as completed in #17740 Jan 4, 2021
ghost pushed a commit that referenced this issue Jan 4, 2021
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables
Projects
None yet
3 participants