-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Event Hubs] Exclude Legacy Packages from Pipelines #17659
Conversation
The focus of these changes is to remove the legacy packages from the build pipeline definitions, as they're now covered under a dedicated set of pipeline definitions. This is intended to allow the T1 and T2 Event Hubs packages to be treated as separate units of work, as they will continue to evolve independently and are maintained by different teams.
|
||
extends: | ||
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml | ||
parameters: | ||
ServiceDirectory: eventhub | ||
ExcludeProjects: | ||
- Azure.ResourceManager.EventHubs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wildcard should be sufficient, but there's one outstanding observation from the initial round of testing where it's not 100% confirmed for one of our script calls.
My approach here was to explicitly define everything that exists today and leave the wild card to provide some level of filtering for anything new. I'm still working with members of the engineering team to investigate and will open a new PR to trim to just the wild card, if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a similar wildcard to the exclude lists above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ones above are owned by the DevOps config and have to be in the raw path format. Unfortunately, they don't support wildcard patterns.
/check-enforcer override |
The focus of these changes is to remove the legacy packages from the build pipeline definitions, as they're now covered under a dedicated set of pipeline definitions. This is intended to allow the T1 and T2 Event Hubs packages to be treated as separate units of work, as they will continue to evolve independently and are maintained by different teams.
Summary
The focus of these changes is to remove the legacy packages from the build pipeline definitions, as they're now covered under a dedicated set of pipeline definitions. This is intended to allow the T1 and T2 Event Hubs packages to be treated as separate units of work, as they will continue to evolve independently
and are maintained by different teams.
Note: This set of changes depends on #17658, which should be committed and validated first. In addition, the new T1-centric pipeline definitions should be created prior to merging these changes.
Last Upstream Rebase
Monday, December 21, 11:55am (EST)
References and Related