Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Exclude Legacy Packages from Pipelines #17659

Merged
merged 1 commit into from
Jan 4, 2021
Merged

[Event Hubs] Exclude Legacy Packages from Pipelines #17659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions sdk/eventhub/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ trigger:
paths:
include:
- sdk/eventhub/

exclude:
- sdk/eventhub/Azure.ResourceManager.EventHubs
- sdk/eventhub/Microsoft.Azure.EventHubs
- sdk/eventhub/Microsoft.Azure.EventHubs.Processor
- sdk/eventhub/Microsoft.Azure.EventHubs.ServiceFabricProcessor
- sdk/eventhub/Microsoft.Azure.Management.EventHub
pr:
branches:
include:
Expand All @@ -20,24 +25,28 @@ pr:
paths:
include:
- sdk/eventhub/
exclude:
- sdk/eventhub/Azure.ResourceManager.EventHubs
- sdk/eventhub/Microsoft.Azure.EventHubs
- sdk/eventhub/Microsoft.Azure.EventHubs.Processor
- sdk/eventhub/Microsoft.Azure.EventHubs.ServiceFabricProcessor
- sdk/eventhub/Microsoft.Azure.Management.EventHub

extends:
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: eventhub
ExcludeProjects:
- Azure.ResourceManager.EventHubs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard should be sufficient, but there's one outstanding observation from the initial round of testing where it's not 100% confirmed for one of our script calls.

My approach here was to explicitly define everything that exists today and leave the wild card to provide some level of filtering for anything new. I'm still working with members of the engineering team to investigate and will open a new PR to trim to just the wild card, if possible.

Copy link
Member

@christothes christothes Jan 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a similar wildcard to the exclude lists above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones above are owned by the DevOps config and have to be in the raw path format. Unfortunately, they don't support wildcard patterns.

- Microsoft.Azure.EventHubs
- Microsoft.Azure.EventHubs.Processor
- Microsoft.Azure.EventHubs.ServiceFabricProcessor
- Microsoft.Azure.EventHubs.*
ArtifactName: packages
Artifacts:
- name: Azure.Messaging.EventHubs
safeName: AzureMessagingEventHubs
- name: Azure.Messaging.EventHubs.Processor
safeName: AzureMessagingEventHubsProcessor
- name: Microsoft.Azure.EventHubs
safeName: MicrosoftAzureEventHubs
- name: Microsoft.Azure.EventHubs.Processor
safeName: MicrosoftAzureEventHubsProcessor
- name: Microsoft.Azure.EventHubs.ServiceFabricProcessor
safeName: MicrosoftAzureEventHubsServiceFabricProcessor
- name: Microsoft.Azure.WebJobs.Extensions.EventHubs
safeName: MicrosoftAzureWebJobsExtensionsEventHubs
- name: Azure.ResourceManager.EventHubs
safeName: AzureResourceManagerEventHubs
6 changes: 6 additions & 0 deletions sdk/eventhub/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@ extends:
MaxParallel: 6
ServiceDirectory: eventhub
TimeoutInMinutes: 190
ExcludeProjects:
- Azure.ResourceManager.EventHubs
- Microsoft.Azure.EventHubs
- Microsoft.Azure.EventHubs.Processor
- Microsoft.Azure.EventHubs.ServiceFabricProcessor
- Microsoft.Azure.EventHubs.*
Clouds: 'Public,Canary'