Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKR is not supported by KV 7.3-preview #22750

Closed
3 tasks done
heaths opened this issue Jul 20, 2021 · 1 comment · Fixed by #26793
Closed
3 tasks done

SKR is not supported by KV 7.3-preview #22750

heaths opened this issue Jul 20, 2021 · 1 comment · Fixed by #26793
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable
Milestone
Backlog

Comments

@heaths
Copy link
Member

heaths commented Jul 20, 2021 •
edited
Loading

Related to #22312, once SKR is supported by Key Vault:

  • Remove commented code mentioning this bug e.g., in KeyClientLiveTests.SecureKeyRelease.cs.
  • Update KeyVaultTestEnvironment.cs to make AttestationUri a required parameter.
  • Remove enableHsm conditions on mock attestation service elements in test-resources.json to install unconditionally.
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable labels Jul 20, 2021
@heaths heaths added this to the [2021] August milestone Jul 20, 2021
@heaths heaths self-assigned this Jul 20, 2021
@heaths heaths modified the milestones: [2021] August, [2021] September Aug 2, 2021
@heaths
Copy link
Member Author

heaths commented Sep 24, 2021

Not available in all regions yet. Punting till November (might be toward end of November, though).

@heaths heaths mentioned this issue Oct 4, 2021
Merged
@jsquire jsquire modified the milestones: [2021] November, Backlog Nov 18, 2021
@heaths heaths modified the milestones: Backlog, [2022] January Jan 4, 2022
@jsquire jsquire modified the milestones: [2022] January, Backlog Jan 18, 2022
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Feb 4, 2022
@heaths
Enable SKR for both KV and MHSM
7e66fd9 
Resolves Azure#22750
@heaths heaths mentioned this issue Feb 4, 2022
Merged
heaths added a commit that referenced this issue Feb 8, 2022
@heaths
Prepare for Key Vault beta release (#26793)
aea323c 
* Regenerate Administration on latest 7.3-preview

* Re-enable backup/restore tests

Resolves #26122

* Add KeyReleasePolicy.Immutable property

Resolves #26364

* Enable SKR for both KV and MHSM

Resolves #22750

* Resolve build issues

* Change ISO8601 durations to strings

* Resolve PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Prepare for Key Vault beta release heaths/azure-sdk-for-net
2 participants
@jsquire @heaths