Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormRecognizer] Migrate to test-proxy #26612

Closed
kinelski opened this issue Jan 26, 2022 · 1 comment
Closed

[FormRecognizer] Migrate to test-proxy #26612

kinelski opened this issue Jan 26, 2022 · 1 comment
Assignees
@JoshLove-msft
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Milestone
[2022] February

Comments

@kinelski
Copy link
Member

kinelski commented Jan 26, 2022 •
edited
Loading

We needed to revert part of the changes introduced in #25879 because tests using the DisableRequestBodyRecording scope would fail in Record mode (even though they work just fine when running Live).

Now we need to understand what exactly is causing the problem, fix it, and remove the useLegacyTransport: true argument we pass in the DocumentAnalysisLiveTestBase and FormRecognizerLiveTestBase constructors.

Note: the constructor changes mentioned above have only been applied in the feature/formrecognizer/v400b3 feature branch of the private repo for now. It will eventually be merged into the public repo.

Related discussion (private repo): https://github.com/Azure/azure-sdk-for-net-pr/pull/1562/files#r792266132
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 26, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer needs-team-triage Workflow: This issue needs the team to triage. labels Jan 26, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 26, 2022
@kinelski kinelski removed the needs-team-triage Workflow: This issue needs the team to triage. label Jan 26, 2022
@kinelski kinelski added this to the [2022] February milestone Jan 26, 2022
@JoshLove-msft JoshLove-msft self-assigned this Jan 26, 2022
@JoshLove-msft
Copy link
Member

I can re-migrate once Azure/azure-sdk-tools#2434 is addressed in Test Proxy.

@JoshLove-msft JoshLove-msft mentioned this issue Feb 8, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshLove-msft JoshLove-msft

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
[2022] February
Development

No branches or pull requests
3 participants
@kinelski @azure-sdk @JoshLove-msft