Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support skipping recording #26847

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Support skipping recording #26847

merged 2 commits into from
Feb 8, 2022

Conversation

JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Feb 8, 2022 •
edited
Loading

Addresses #26612

@ghost ghost added the Azure.Core label Feb 8, 2022
@check-enforcer
Copy link

check-enforcer bot commented Feb 8, 2022

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

@JoshLove-msft JoshLove-msft marked this pull request as ready for review February 8, 2022 05:25
@JoshLove-msft
Copy link
Member Author

@kinelski if you can please confirm that recording works as expected with these changes. I tried running the resource creation script but kept hitting failures.

jsquire
jsquire approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form Recognizer bits look good to me.

annelo-msft
annelo-msft approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM re: Core, pending comment resolution.

@kinelski
Copy link
Member

kinelski commented Feb 8, 2022

@kinelski if you can please confirm that recording works as expected with these changes. I tried running the resource creation script but kept hitting failures.

I can confirm I could record/playback Form Recognizer with no issues. Thank you for the fix!

@JoshLove-msft JoshLove-msft merged commit f6945ef into Azure:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annelo-msft annelo-msft annelo-msft approved these changes

@jsquire jsquire jsquire approved these changes

@heaths heaths heaths approved these changes

@benbp benbp Awaiting requested review from benbp

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@kinelski kinelski Awaiting requested review from kinelski kinelski is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@maririos maririos Awaiting requested review from maririos

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshLove-msft @kinelski @jsquire @heaths @annelo-msft