Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] net-core-ci failure #45806

Closed
live1206 opened this issue Sep 5, 2024 · 7 comments · Fixed by #46909
Closed

[BUG] net-core-ci failure #45806

live1206 opened this issue Sep 5, 2024 · 7 comments · Fixed by #46909
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Extensions ASP.NET Core extensions

Comments

@live1206
Copy link
Member

live1206 commented Sep 5, 2024

Library name and version

Microsoft.Extensions.Azure

Describe the bug

In #45617, net-core-ci is failing

##[error]sdk/extensions/Microsoft.Extensions.Azure/tests/ClientFactoryTests.cs(340,65): Error CS1061: 'ManagedIdentityClient' does not contain a definition for 'ClientId' and no accessible extension method 'ClientId' accepting a first argument of type 'ManagedIdentityClient' could be found (are you missing a using directive or an assembly reference?)

Expected behavior

net-core-ci should apss

Actual behavior

net-core-ci is failing

Reproduction Steps

https://dev.azure.com/azure-sdk/public/_build/results?buildId=4109288&view=logs&j=8f1d288f-f763-5c12-3b1b-d79c9adacead&t=1a409d55-c12a-5808-4a50-b8ba34872ec8&l=110

Environment

No response

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Extensions ASP.NET Core extensions needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@live1206
Copy link
Member Author

live1206 commented Sep 5, 2024

This is caused by https://github.com/Azure/azure-sdk-for-net/pull/45605/files#diff-d57af0cecc76209f260c1b472129fa94c52c4316921eb35d2646b3b0b61bf413.
With project reference, ClientId and
ResourceIdentifier have been removed and the test could not build.
And the changes of the PR doesn't trigger net-core-ci in it, but it breaks net-core-ci.

@jsquire
Copy link
Member

jsquire commented Sep 5, 2024

@live1206 : Please do not assign issues directly. Leave it in a "needs-team-triage" state and let our process find the right person.

@jsquire
Copy link
Member

jsquire commented Sep 5, 2024

@christothes: This looks to be related to the Object Id changes. Can you please take a look?

@jsquire jsquire removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 5, 2024
@live1206
Copy link
Member Author

live1206 commented Sep 5, 2024

@live1206 : Please do not assign issues directly. Leave it in a "needs-team-triage" state and let our process find the right person.

image
It was assigned by the bot though.

@jsquire
Copy link
Member

jsquire commented Sep 5, 2024

@live1206 : Please do not assign issues directly. Leave it in a "needs-team-triage" state and let our process find the right person.

image It was assigned by the bot though.

My bad. I overlooked that. Bad bot. bad.

@christothes
Copy link
Member

This test fails because it is relying on internal fields which changed recently. We can resolve it once Identity ships.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Extensions ASP.NET Core extensions
Projects
None yet
3 participants