Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore failing tests to make CI pass with project reference #45807

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Ignore failing tests to make CI pass with project reference #45807

merged 3 commits into from
Sep 5, 2024

Conversation

live1206
Copy link
Member

@live1206 live1206 commented Sep 5, 2024

Workaround for #45806 to make net-core-ci pass.

@live1206 live1206 requested a review from jsquire as a code owner September 5, 2024 03:36
@github-actions github-actions bot added the Extensions ASP.NET Core extensions label Sep 5, 2024
@live1206
Copy link
Member Author

live1206 commented Sep 5, 2024

@jsquire
We need to have this workaround firstly to unblock the PRs in azure-sdk-for-net.
#45806 is filed for a proper fix.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@live1206 live1206 changed the title Comment test out to make it build with project reference. Ignore failing tests to make CI pass with project reference Sep 5, 2024
@live1206
Copy link
Member Author

live1206 commented Sep 5, 2024 •
edited
Loading

Since net-core-ci is not triggered here, verified in https://dev.azure.com/azure-sdk/public/_build/results?buildId=4109564&view=results with the same change in #45617.

@live1206 live1206 merged commit 6921884 into Azure:main Sep 5, 2024
17 checks passed
@live1206 live1206 deleted the fix-net-core-ci branch September 5, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

Assignees
No one assigned
Labels
Extensions ASP.NET Core extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@live1206 @azure-sdk @ArcturusZhang