Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormRecognizer] Whitelist redacted query parameters for logging #12344

Merged
merged 2 commits into from
May 28, 2020

Conversation

kinelski
Copy link
Member

Missing changes that were not included in #12285, as pointed out here.

The query parameters being exposed can only assume a discrete amount of values (true, false, "summary" and "full"), and won't include information that's unsafe to log.

@kinelski kinelski added Cognitive Services Client This issue points to a problem in the data-plane of the library. Docs FormRecognizer labels May 28, 2020
@kinelski kinelski self-assigned this May 28, 2020
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kinelski kinelski merged commit 9b2a8bd into Azure:master May 28, 2020
@kinelski kinelski deleted the fr-query branch May 28, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer Cognitive Services Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants