Fix bug on create OCI Manifest #17379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
customer-reported
|
Thank you for your contribution clarelimo! We will review the pull request and get back to you soon. |
avtakkar
reviewed
Dec 7, 2020
sdk/containerregistry/Microsoft.Azure.ContainerRegistry/src/Generated/ManifestsOperations.cs
Outdated
Show resolved
Hide resolved
sdk/containerregistry/Microsoft.Azure.ContainerRegistry/src/Generated/ManifestsOperations.cs
Show resolved
Hide resolved
sdk/containerregistry/Microsoft.Azure.ContainerRegistry/src/Generated/ManifestsOperations.cs
Outdated
Show resolved
Hide resolved
sdk/containerregistry/Microsoft.Azure.ContainerRegistry/tests/Tests/ManifestTests.cs
Outdated
Show resolved
Hide resolved
sdk/containerregistry/Microsoft.Azure.ContainerRegistry/tests/Tests/ManifestTests.cs
Outdated
Show resolved
Hide resolved
sdk/containerregistry/Microsoft.Azure.ContainerRegistry/tests/Tests/ManifestTests.cs
Outdated
Show resolved
Hide resolved
jsquire
added
Client
yugangw-msft
approved these changes
Jan 5, 2021
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
* Fix bug on create OCI Manifest * Added other manifests session records * Resolved PR comments * Updated the switch statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unable to create OCI manifest in Azure Container Registry
Issue Statement
The SDK doesn't enable the client to create an OCI manifest.
This issue is tracked at Azure/azure-sdk-for-net.
Root Cause Analysis
The MediaType used in the http request headers(content type) was that of a V2Manifest leaving out all the other MediaTypes for other types of manifests.
Resolution
To fix the issue, the media type was added as a parameter in each of the manifest types and all of them were fetched in the _httpRequest.Content.Headers.ContentType.
Tests
Automated tests were added to create the different manifests and they were all successful.