[MetricsAdvisor] Added tests for Data Feed CRUD operations (2/4) #17750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
Client
christothes
approved these changes
Jan 5, 2021
...dvisor/Azure.AI.MetricsAdvisor/tests/MetricsAdvisorAdministrationClient/DataFeedLiveTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15913.
This PR is part of a huge set of changes that fixes the issue mentioned above. These changes were separated into 4 chunks to reduce the review burden. This PR consists of:
DataFeedtests for Update methods. Two tests were added for every possible type of data feed (13 types). The tests are pretty much the same, so the validation and setup logic could easily be extracted into separate methods.DataFeedtest for the Delete method. A single test was added and follows the same pattern as other tests for Delete methods.The added tests only take into consideration updates for data feeds with minimum setup configuration. Data feeds with more members set will be tested in the next PR.