Use PostConfigure for InitialOffsetOptions #17778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
approved these changes
Jan 5, 2021
pakrym
reviewed
Jan 5, 2021
| } | ||
|
|
||
| [Test] | ||
| public void InitializeFromCodeRespectsFinalOffsetOptions_FromStart() |
pakrym
approved these changes
Jan 5, 2021
|
FYI @jsquire This seems to be that same Claims issue where we may want to add a delay after resource creation. I can add in the same fix that we did for SB if you'd like. |
|
@JoshLove-msft: Sure looks that way; I've been meaning to steal your work and copy it over but haven't yet. If you'd like to beat me to it, please feel free. |
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hello @JoshLove-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
PostConfigure ensures that the InitialOffsetOptions will be propagated to the EventProcessorOptions regardless of the ordering used when doing configuration.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostConfigure ensures that the InitialOffsetOptions will be propagated to the EventProcessorOptions regardless of the ordering used when doing configuration.