Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perf tests for Blob storage scenarios. #17897

Conversation

Mohit-Chakraborty
Copy link
Contributor

Create stand-alone test apps for Azure.Storage.Blobs and Microsoft.Azure.Storage.Blob

Create stand-alone test apps for Azure.Storage.Blobs and Microsoft.Azure.Storage.Blob
@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jan 11, 2021
Reuse stream where possible.
@jaschrep-msft
Copy link
Member

These elements are just fine on their own, but this places current and legacy perf tests side-by-side when there are no controls into the parallelism of individual methods. It probably won't make a difference for testing small files, but when testing files that the SDKs partition for upload/download, they choose very different parallelism values by default; current chooses 2 and legacy chooses a function of logical cores on the machine. Unless we truly just want to compare defaults, which we could "fix" by just bumping the default core count for the current SDK, I worry the results generated by this code will lead us to wrong conclusions when comparing the different storage SDKs.

@Mohit-Chakraborty
Copy link
Contributor Author

this places current and legacy perf tests side-by-side when there are no controls into the parallelism of individual methods.

The 2 tests are supposed to be run independently with individual controls of the degree of parallelism, load size and other tweakable parameters.

@Mohit-Chakraborty Mohit-Chakraborty merged commit c06da06 into Azure:master Jan 12, 2021
@Mohit-Chakraborty Mohit-Chakraborty deleted the dev/mohitc/AzureBlobStoragePerfTests branch January 12, 2021 19:59
minnieliu pushed a commit to minnieliu/azure-sdk-for-net that referenced this pull request Jan 23, 2021
* Add perf tests for Blob storage scenarios.

Create stand-alone test apps for Azure.Storage.Blobs and Microsoft.Azure.Storage.Blob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants