Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating UbuntuNetCoreKeyring dockerfile to use net core 5 #17980

Merged
merged 5 commits into from
Feb 22, 2021
Merged

Updating UbuntuNetCoreKeyring dockerfile to use net core 5 #17980

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cecc380
Updating UbuntuNetCoreKeyring dockerfile to use net core 5
schaabs Jan 14, 2021
37cc1ce
Update ubuntu netcore keyring dockerfile to use net 5
benbp Jan 14, 2021
8424425
Merge pull request #2 from benbp/benbp/keyring-dockerfile
schaabs Jan 14, 2021
c279c9e
adding python to installed packages
schaabs Jan 15, 2021
afb85d9
Merge branch 'keyring-container-update' of https://github.com/schaabs…
schaabs Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions eng/containers/UbuntuNetCoreKeyring/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,24 @@
FROM mcr.microsoft.com/dotnet/core/sdk:3.1-bionic AS build
FROM mcr.microsoft.com/dotnet/sdk:5.0-focal AS build

ENV \
NO_AT_BRIDGE=1 \
DOCKER_CONTAINER_NAME="ubuntu_netcore_keyring" \
PSModuleAnalysisCachePath=/var/cache/microsoft/powershell/PSModuleAnalysisCache/ModuleAnalysisCache \
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetCoreSDK-Ubuntu-18.04
POWERSHELL_DISTRIBUTION_CHANNEL=PSDocker-DotnetCoreSDK-Ubuntu-20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does .NET 5 require Ubuntu20?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly ask because we are still using ubuntu 18 in most of our other pipelines.

Copy link
Member Author

@schaabs schaabs Jan 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see a docker image for 5.0 based on Ubuntu 18 in the the full tag listing here. If you think it's an issue to use Ubuntu 20 here we can build our own image.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting they seem to support .NET 5 on 18.04 (https://docs.microsoft.com/en-us/dotnet/core/install/linux#ubuntu) but they don't publish a docker container. I don't know of any specific issues with Ubuntu 20.04 currently but I know the last time we tried moving there were some sorting issues due to some cultural library changes in the OS. You can certainly try 20.04 if that is easier but if you start seeing weird issues we might want to reconsider until we move everything to 20.04.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard the only issue we've found so far was python was not installed by default, but if we see more we can build one from 18.04.


# Install GNOME keyring
RUN apt-get update \
&& apt-get install -y \
libsecret-1-dev \
dbus-x11 \
gnome-keyring
gnome-keyring \
python

# Install PowerShell && .net core runtime 2.1
RUN wget -q https://packages.microsoft.com/config/ubuntu/18.04/packages-microsoft-prod.deb \
RUN wget -q https://packages.microsoft.com/config/ubuntu/20.04/packages-microsoft-prod.deb \
&& dpkg -i packages-microsoft-prod.deb \
&& apt-get update \
&& apt-get install -y powershell \
&& pwsh --version \
&& apt-get install -y dotnet-runtime-2.1 \
&& dotnet --list-runtimes
&& dotnet --list-runtimes