Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] - Common - Rename Id to UserId #17983

Merged
merged 2 commits into from
Jan 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ public CommunicationUserIdentifier(string id) { }
public partial class MicrosoftTeamsUserIdentifier : Azure.Communication.CommunicationIdentifier
{
public MicrosoftTeamsUserIdentifier(string userId, bool isAnonymous = false) { }
public string Id { get { throw null; } }
public bool IsAnonymous { get { throw null; } }
public string UserId { get { throw null; } }
}
[System.Diagnostics.DebuggerDisplayAttribute("{Value}")]
public partial class PhoneNumberIdentifier : Azure.Communication.CommunicationIdentifier
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Azure.Communication
public class MicrosoftTeamsUserIdentifier : CommunicationIdentifier
{
/// <summary>The id of the Microsoft Teams user. If the user isn't anonymous, the id is the AAD object id of the user.</summary>
public string Id { get; }
public string UserId { get; }

/// <summary>True if the user is anonymous, for example when joining a meeting with a share link.</summary>
public bool IsAnonymous { get; }
Expand All @@ -28,7 +28,7 @@ public class MicrosoftTeamsUserIdentifier : CommunicationIdentifier
public MicrosoftTeamsUserIdentifier(string userId, bool isAnonymous = false)
{
Argument.AssertNotNullOrEmpty(userId, nameof(userId));
Id = userId;
UserId = userId;
IsAnonymous = isAnonymous;
}
}
Expand Down