[MetricsAdvisor] Added AAD support #18036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
Do Not Merge
Client
|
/azp run net - metricsadvisor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - metricsadvisor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - metricsadvisor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
christothes
reviewed
Jan 19, 2021
...etricsAdvisor/tests/MetricsAdvisorAdministrationClient/AnomalyAlertConfigurationLiveTests.cs
Show resolved
Hide resolved
christothes
approved these changes
Jan 19, 2021
kinelski
changed the title
maririos
reviewed
Jan 20, 2021
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorAdministrationClient.cs
Show resolved
Hide resolved
maririos
reviewed
Jan 20, 2021
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="MetricsAdvisorClient"/> class. | ||
| /// </summary> | ||
| /// <param name="endpoint">The endpoint to use for connecting to the Form Recognizer Azure Cognitive Service.</param> |
There was a problem hiding this comment.
to the Metrics Advisor ... service
There was a problem hiding this comment.
I was pretty sure my copy-pasting wouldn't be exposed. I failed this time.
There was a problem hiding this comment.
My next PR will update the README with AAD info, so I'll include these doc fixes there.
maririos
reviewed
Jan 20, 2021
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorAdministrationClient.cs
Show resolved
Hide resolved
maririos
reviewed
Jan 20, 2021
minnieliu
pushed a commit
to minnieliu/azure-sdk-for-net
that referenced
this pull request
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding AAD support to Metrics Advisor. Changes:
useTokenCredentialbool test parameter).test-resources.jsonto enable AAD credentials in live tests pipeline.Fixes #17768.