Disable default HttpClient/HttpWebRequest timeouts #18050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
||
| // Timeouts are handled by the pipeline | ||
| request.Timeout = Timeout.Infinite; | ||
| request.ReadWriteTimeout = Timeout.Infinite; |
There was a problem hiding this comment.
https://docs.microsoft.com/en-us/dotnet/api/system.net.httpwebrequest.readwritetimeout?view=net-5.0#remarks this talks about timeouts on Stream.Write as well. I recall we apply NetworkTimeout on Stream.Read. How is Stream.Write secured by NetworkTimeout?
There was a problem hiding this comment.
Right now the only Write we do is during content sending. The content is written during the Transport.SendAsync call and is guarded by this timeout:
There was a problem hiding this comment.
Thank you for the thorough review.
kasobol-msft
approved these changes
Jan 19, 2021
pakrym
deleted the
pakrym/Disable-default-HttpClient-HttpWebRequest-timeouts
branch
minnieliu
pushed a commit
to minnieliu/azure-sdk-for-net
that referenced
this pull request
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I double check and all the cases handled by default timeouts are already handled by the Azure.Core pipeline, ResponseBodyPolicy in particular.
Fixes: #18047