Skip empty checkpoints #18059
Merged
Skip empty checkpoints #18059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jsquire
approved these changes
Jan 19, 2021
| @@ -621,7 +621,7 @@ public async Task ListCheckpointsUsesSequenceNumberAsTheStartingPositionWhenNoOf | |||
| /// </summary> | |||
| /// | |||
| [Test] | |||
| public async Task ListCheckpointsUsesSequenceNumberAsTheStartingPositionWhenOffsetIsNullInLegacyCheckpoint() | |||
| public async Task ListCheckpointSkipsCheckpointsWhenOffsetIsNullInLegacyCheckpoint() | |||
There was a problem hiding this comment.
Is it never possible to have a valid sequence with a null offset? If so, we may want to have a couple of additional test scenarios.
There was a problem hiding this comment.
T1 was skipping all checkpoints with empty/null offset https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/eventhub/Microsoft.Azure.EventHubs.Processor/src/AzureStorageCheckpointLeaseManager.cs#L125
I might need a test for empty.
sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/BlobCheckpointStore/BlobsCheckpointStore.cs
Show resolved
Hide resolved
minnieliu
pushed a commit
to minnieliu/azure-sdk-for-net
that referenced
this pull request
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T1 client can write checkpoints with a null offset and 0 sequenceNumber, they should be skipped.