Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceGraph SDK changes for 2021-03-01 API version #19536

Merged
merged 4 commits into from
Mar 29, 2021

Conversation

fenwickt
Copy link
Contributor

@fenwickt fenwickt commented Mar 15, 2021

  • Generated contracts for 2021-03-01 api-version from resourcegraph.json
  • Updated SDK version to 2.1.0
  • Added Manual QueryRequest partial class to pereserve the backward compatibility (as per feedback from the previous PR)
  • Added tests for new tenant and MG scenarios
  • Breaking change - default resultFormatOption is now objectArray instead of table. Our RP still supports 'table' as a default format for older API versions, but it uses 'objectArray' as a default for 2021-03-01

Swagger PR: Azure/azure-rest-api-specs#13380
Automated PR in this repo: https://github.com/AzureSDKAutomation/azure-sdk-for-net/pull/3486/files

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@fenwickt fenwickt marked this pull request as draft March 16, 2021 01:12
@fenwickt fenwickt marked this pull request as ready for review March 18, 2021 05:01
@dramuy
Copy link

dramuy commented Mar 22, 2021

Installing AutoRest version: v2

is this needed to add to repo?


Refers to: eng/mgmt/mgmtmetadata/resourcegraph_resource-manager.txt:1 in b96821f. [](commit_id = b96821f, deletion_comment = False)

@allenjzhang
Copy link
Member

Installing AutoRest version: v2

Yes.Thanks.


In reply to: 804340490 [](ancestors = 804340490)


Refers to: eng/mgmt/mgmtmetadata/resourcegraph_resource-manager.txt:1 in b96821f. [](commit_id = b96821f, deletion_comment = False)

@fenwickt fenwickt requested a review from YalinLi0312 March 29, 2021 17:45
@YalinLi0312
Copy link

/check-enforcer reset

@YalinLi0312 YalinLi0312 merged commit 04b1ad2 into Azure:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants