Batch Control Plane 2021-06-01 update

[paterasMSFT]

Swagger change PR

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

• Please open PR in Draft mode if it is:
  • Work in progress or not intended to be merged.
  • Encountering multiple pipeline failures and working on fixes.
• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
• The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

• Include updated management metadata.
• Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

• If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

• If the check fails at the Verify Code Generation step, please ensure:

  • Do not modify any code in generated folders.
  • Do not selectively include/remove generated files in the PR.
  • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
    Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

  Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

    `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
  

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

[allenjzhang]

/azp run net - mgmt - ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[paterasMSFT]

@allenjzhang CI passing now

[markcowl]

There are some breaking changes here. The changes aoround identity types I think can be easily mitigated by a customization, per the comments.

The breaking change in the constructor for ContainerRegisytry is caused by the way parameters are ordered (optional parameters come after required parameters). I don't think there is an easy mitigation here that is desirable.

[paterasMSFT]

@markcowl could we get an approval here? Time is a factor. Thank you.

[markcowl]

It looks like you addressecd one breaking change issue, but did not address the other two. Did I miss something?

[paterasMSFT]

@markcowl

still a breaking change - the constructor has removed parameters.

Which parameters have been removed? I still see them all there. The type name is shorter, will the old not be coerced into its parent type?

UPDATE: Tested it, and you're right, I do need a wrapping constructor to facilitate the new type. I'll add one now. (Now done)

Still a breaking change, this class is still removed with no mitigation

The generated one is removed, but I put in a manual one that derives from the newly renamed generated class, as discussed: sdk/batch/Microsoft.Azure.Management.Batch/src/Models/BatchAccountIdentityUserAssignedIdentitiesValue.cs

[ghost]

Hello @markcowl!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.