Add System.Text.Json converter for EventGridEvent #22295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
ahamad-MS,
jfggdl and
Kishp01
as code owners
ghost
added
the
JoshLove-msft
commented
Jun 29, 2021
| /// A custom converter that attributes the <see cref="EventGridEvent"/> type. | ||
| /// This allows System.Text.Json to serialize and deserialize EventGridEvent by default. | ||
| /// </summary> | ||
| internal class EventGridEventConverter : JsonConverter<EventGridEvent> |
There was a problem hiding this comment.
This is covered by existing tests after switching the Parse and Publish methods to use this.
|
/azp run net - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
approved these changes
Jun 29, 2021
sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/EventGridEventConverter.cs
Outdated
Show resolved
Hide resolved
|
/azp run net - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JoshLove-msft
force-pushed
the
eg-converter
branch
from
2c73b86 to
0cf5ae3
Compare
|
/azp run net - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pakrym
reviewed
Jun 29, 2021
sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/EventGridEvent.cs
Outdated
Show resolved
Hide resolved
pakrym
approved these changes
Jun 29, 2021
|
/azp run net - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21639