Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpubsub snippets #27360

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

annelo-msft
Copy link
Member

@annelo-msft annelo-msft commented Mar 4, 2022

PR #27350 broke the build's analyze step by not updating snippets. This PR reverts that change to unblock the Core CI.

@annelo-msft annelo-msft requested a review from jsquire March 4, 2022 19:24
@annelo-msft annelo-msft enabled auto-merge (squash) March 4, 2022 19:25
@JoshLove-msft
Copy link
Member

FYI @JialinXin:
Making this update to the preprocessor directives in WebPubSubSample along with deleting the unused snippet regions seems to fix things:

From:
#if NETCOREAPP3_1_OR_GREATER
To:
#if NETCOREAPP3_1_OR_GREATER || SNIPPET

@annelo-msft annelo-msft merged commit d56ebba into Azure:main Mar 4, 2022
yanfa317 pushed a commit to yanfa317/azure-sdk-for-net that referenced this pull request Mar 8, 2022
* Update webpubsub snippets

* change strategies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants