update to translation LRO to not prefecth first page #27365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
reviewed
Mar 4, 2022
sdk/translation/Azure.AI.Translation.Document/tests/TranslationOperationLiveTests.cs
Outdated
Show resolved
Hide resolved
christothes
approved these changes
Mar 4, 2022
yanfa317
pushed a commit
to yanfa317/azure-sdk-for-net
that referenced
this pull request
Mar 8, 2022
* update to translation LRO to not prefecth first page * revert record mode comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
In order to support these changes #27017 that consolidate all of the polling logic for OperationPoller we needed to maintain consistency in what WaitForCompletion and UpdateStatus do. All value construction should be handled by UpdateStatus once you reach a terminal state and WaitForCompletion should simply do the waiting and return the value that UpdateStatus sets.
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.