WIP on new format changes #39817
Merged
WIP on new format changes #39817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
reviewed
Nov 8, 2023
sdk/core/System.Net.ClientModel/src/ModelReaderWriter/IJsonModel.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Nov 8, 2023
sdk/core/System.Net.ClientModel/src/ModelReaderWriter/IModel.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Nov 8, 2023
| { | ||
| bool implementsJson = model is IJsonModel<T>; | ||
| bool isValid = (format == ModelReaderWriterFormat.Json && implementsJson) || format == "W"; | ||
| bool isValid = (format == "J" && implementsJson) || format == "W"; |
There was a problem hiding this comment.
Curious: would it be valid to do
Suggested change
| bool isValid = (format == "J" && implementsJson) || format == "W"; | |
| bool isValid = (format == ModelReaderWriterOptions.Json.Format && implementsJson) || format == ModelReaderWriterOptions.Json.Format; |
Asking for two reasons:
- To see if I'm understanding how this works correctly
- Because if we can, I think that'd be preferable to avoid "magic numbers" type errors
There was a problem hiding this comment.
We would need to duplicate the constants in all libraries since all libraries will have models which will need to compare against these values.
This is one of the "downsides" to removing the ModelReaderWriterFormat, but it removes ambiguity around the conceptual formats wire and data and the concrete data interchange formats json, xml, etc.
m-nash
requested review from
KrzysztofCwalina,
tg-msft,
JoshLove-msft and
christothes
as code owners
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Nov 22, 2023
…zure#39478) * initial move to separate model reader writer in System.Net.ClientModel * update api * update doc settings for readme * address pr feedback * first cut at readme / changelog * fix perf issue in helper methods * add perf for srcgen * address feedback * update IModel to have a GetWireFormat * update api * update ci * remove GetOptions * WIP on new format changes (Azure#39817) * wip on new format changes * more tweaks to the API * impl tweaks * address feedback * update api * fix tests * address feedback * rename based on feedback (Azure#39885) * Remove wire (Azure#40021) * remove wire * Update sdk/core/Azure.Core/tests/common/Internal/ModelReaderWriterHelper.cs Co-authored-by: Anne Thompson <[email protected]> * revert nullability since azure core tests don't support this right now --------- Co-authored-by: Anne Thompson <[email protected]> * Rename package (Azure#40030) * rename package * comment out bad test * feedback * more feedback * update basic sample * remove next steps * update docs * address feedback * remove unused frozen code * address feedback * address additional feedback * update ci.yml * move file inside mrw folder * Add exception documentation * move helper file * update comment * readme feedback * follow static field convention * remove unecessary interlock * add azure sdk analyzers back * throw when cancelled * remove unused #if * remove azureicon * update readme * fix package icon * remove unnecessary conditions --------- Co-authored-by: Anne Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.