-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix recommendation engine APIs along with resource property fixes, add new APIs and tests #4110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run generate.cmd
to generate the code. This should also generate a .txt
file, please commit the file.
(If the file is not generate please pull down the latest changes and try again)
I ran generate.cmd and a file named src\SDKs_metadata\web_resource_manager.txt was created. Is this what I need to commit? |
@michimune yes |
@dsgouda Pushed the .txt file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shahabhijeet please merge when ready |
@michimune There are few more things to be done here
This should update the |
@dsgouda Pushed another commit. How does this look? |
@michimune taking a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @shahabhijeet PTAL and merge
Thank you! |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.