Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recommendation engine APIs along with resource property fixes, add new APIs and tests #4110

Merged
merged 7 commits into from
Mar 15, 2018

Conversation

michimune
Copy link

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda dsgouda self-assigned this Mar 6, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run generate.cmd to generate the code. This should also generate a .txt file, please commit the file.
(If the file is not generate please pull down the latest changes and try again)

@michimune
Copy link
Author

I ran generate.cmd and a file named src\SDKs_metadata\web_resource_manager.txt was created. Is this what I need to commit?

@dsgouda
Copy link
Contributor

dsgouda commented Mar 7, 2018

@michimune yes

@michimune
Copy link
Author

@dsgouda Pushed the .txt file.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Mar 7, 2018

@shahabhijeet please merge when ready

@dsgouda
Copy link
Contributor

dsgouda commented Mar 7, 2018

@michimune There are few more things to be done here

  1. Msbuild build.proj (this will download latest build tools)
  2. Use generate.cmd to generate your SDK
  3. Build you sdk using msbuild build.proj /t:Build /p:Scope=SDKs\Websites
  4. This will add all the meta data that is required

This should update the .props file and also generate a new SDKInfo*.cs file. Please commit these changes.

@michimune
Copy link
Author

@dsgouda Pushed another commit. How does this look?

@dsgouda
Copy link
Contributor

dsgouda commented Mar 8, 2018

@michimune taking a look

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @shahabhijeet PTAL and merge

@dsgouda dsgouda merged commit bde6487 into Azure:psSdkJson6 Mar 15, 2018
@michimune
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants