Add DeploymentStacks APIs #44254
Add DeploymentStacks APIs #44254
Conversation
github-actions
bot
added
the
Mgmt
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| public DeploymentStacksTemplateLink TemplateLink { get; set; } | ||
| /// <summary> Name and value pairs that define the deployment parameters for the template. Use this element when providing the parameter values directly in the request, rather than linking to an existing parameter file. Use either the parametersLink property or the parameters property, but not both. </summary> | ||
| [WirePath("properties.parameters")] | ||
| public IDictionary<string, DeploymentParameter> Parameters { get; } |
There was a problem hiding this comment.
Parameters should be settable. I'm unsure why it is being generated as read-only. We are mimicking deployment parameters here and in the ArmDeploymentProperties, the parameters property is binary data. I'm wondering if we should be following the same pattern here.
There was a problem hiding this comment.
The .Net SDK design enforces that all collection properties are immutable. To manipulate the elements within the collection—such as adding, removing, or updating items—please utilize the collection’s methods. Here for the Parameters collection, please use Add method to insert new parameters.
|
|
||
| /// <summary> Initializes a new instance of <see cref="DeploymentStackData"/>. </summary> | ||
| /// <param name="location"> The location. </param> | ||
| public DeploymentStackData(AzureLocation location) : base(location) |
There was a problem hiding this comment.
Should this be public? I don't think the user should be initializing these lists as they should be populated by the service.
There was a problem hiding this comment.
This can be used for Create\Update\Validate operation
| } | ||
| } | ||
|
|
||
| internal RequestUriBuilder CreateListAtCopeRequestUri(string scope) |
There was a problem hiding this comment.
Should this be "CreateListAtScopeRequestUri"?
|
#44405 is the new pr for this effort |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.