-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Azure.Storage.Files.DataLake download APIs are in feature parity with Azure.Storage.Blobs #45498
Conversation
A few things of note:
Let me know thoughts and if I should incorporate anything. Thanks |
API change check APIView has identified API level changes in this PR and created following API reviews. |
The tests are here:
That being true, I would still like the E2E tests, as that follows the current testing standard we do for when we add any new API. |
sdk/storage/Azure.Storage.Files.DataLake/src/Models/DataLakeFileReadResult.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on organization and presentation.
sdk/storage/Azure.Storage.Files.DataLake/samples/Sample01a_HelloWorld.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.Files.DataLake/samples/Sample01a_HelloWorld.cs
Outdated
Show resolved
Hide resolved
@nickliu-msft yes, but we are not just testing that the blobs download works correctly, we are testing that our arguments are mapped onto it correctly and our results are properly translated. Ideally, we would have mocking foundation in place to more directly test that, but for now recordings will have to do. (Also though it's good to have some full end to end tests as well so we'd still have some of these even if we were able to go with a mocking route.) |
Resolves #45418