[Do Not Merge] RecoveryServices.Backup update for latest release #4613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
dsgouda
suggested changes
Jul 31, 2018
| /// </summary> | ||
| [JsonProperty(PropertyName = "mabServerType")] | ||
| public string MabServerType { get; set; } |
There was a problem hiding this comment.
These are breaking changes, please bump the assembly version to 3.1.0-preview
| @@ -7,8 +7,8 @@ | |||
| [assembly: AssemblyTitle("Microsoft Azure Recovery Services Backup Library")] | |||
| [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Recovery Services Backup Resources.")] | |||
|
|
|||
| [assembly: AssemblyVersion("3.0.0.0")] | |||
| [assembly: AssemblyFileVersion("3.0.0.0")] | |||
| [assembly: AssemblyVersion("3.0.0.1")] | |||
There was a problem hiding this comment.
AssemblyVersion remains the same, AssemblyFileVersion must be updated
| @@ -6,7 +6,7 @@ | |||
| <PropertyGroup> | |||
| <PackageId>Microsoft.Azure.Management.RecoveryServices.Backup</PackageId> | |||
| <Description>Provides developers with libraries for the updated recovery services backup feature under Azure Resource manager.</Description> | |||
| <Version>3.0.0-preview</Version> | |||
| <Version>3.0.1-preview</Version> | |||
| <AssemblyName>Microsoft.Azure.Management.RecoveryServices.Backup</AssemblyName> | |||
| <PackageTags>Recoveryservices;Backup;</PackageTags> | |||
| <PackageReleaseNotes/> | |||
There was a problem hiding this comment.
Please add meaningful information in the PackageReleaseNotes similar to this
|
@sumitmal Please join the Azure org as suggested. Will close the PR by next week if there is no activity |
Generated using Generate.ps1
|
Resolved following comments @dsgouda
|
dsgouda
suggested changes
Aug 9, 2018
| @@ -7,8 +7,8 @@ | |||
| [assembly: AssemblyTitle("Microsoft Azure Recovery Services Backup Library")] | |||
| [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure Recovery Services Backup Resources.")] | |||
|
|
|||
| [assembly: AssemblyVersion("3.0.0.0")] | |||
| [assembly: AssemblyFileVersion("3.0.0.0")] | |||
| [assembly: AssemblyVersion("3.1.0.0")] | |||
There was a problem hiding this comment.
Please keep the AssemblyVersion unchanged here
|
@dsgouda done |
|
Will merge on CIs passing |
shahabhijeet
changed the title
shahabhijeet
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure/azure-rest-api-specs#3395
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.