Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.ContainerInstance: 2024-05-01-preview api .NET SDK #46343

Conversation

drishtipeshwani09
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Sep 27, 2024
@archerzz
Copy link
Member

@drishtipeshwani09 please fix the errors in build, thanks.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.ContainerInstance

@drishtipeshwani09
Copy link
Contributor Author

drishtipeshwani09 commented Sep 30, 2024

The build errors are fixed

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Arthur's team is unavailable this week, approving based on the feview from kaushik-ms. Advised that they'll need to onboard to the Azure SDK repository to ber able to self-review and merge going forward.

@jsquire jsquire merged commit 340b722 into Azure:main Oct 3, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants