Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SDK update for Automation - 3.3.0-preview #4641

Merged

Conversation

Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Aug 7, 2018

Description

Contains changes introduced in the following spec:
Azure/azure-rest-api-specs#3580

Other changes:

Enabled the SourceControlSyncJobs test and rerecorded it.
Bumped up the version of the SDK - 3.3.0-preview.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@Francisco-Gamino Francisco-Gamino changed the title New SDK update for Automation. New SDK update for Automation - 3.3.0-preview Aug 7, 2018
@Francisco-Gamino
Copy link
Contributor Author

Adding @vrdmr for FYI.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Aug 7, 2018

Great! Thanks for your review @vrdmr!

@Francisco-Gamino
Copy link
Contributor Author

@dsgouda @shahabhijeet : Could you please take a look when you have a moment?

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 859e42c into Azure:psSdkJson6 Aug 8, 2018
@Francisco-Gamino
Copy link
Contributor Author

Awesome! Thanks @dsgouda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants