Update dependencies of SignalR extensions #48280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Sindo
requested review from
JoshLove-msft,
christothes,
annelo-msft,
KrzysztofCwalina,
tg-msft,
jsquire,
m-nash,
ArthurMa1978,
chenkennt,
vicancy and
JialinXin
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
JialinXin
approved these changes
Feb 13, 2025
vicancy
approved these changes
Feb 13, 2025
jsquire
approved these changes
Feb 13, 2025
sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/CHANGELOG.md
Outdated
Show resolved
Hide resolved
....Azure.WebJobs.Extensions.SignalRService/src/Config/SignalRFunctionsHostBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Y-Sindo
force-pushed
the
signalrversionconflict
branch
from
fdf7ecb to
076fb0d
Compare
jsquire
requested changes
Feb 18, 2025
...bJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj
Outdated
Show resolved
Hide resolved
...bJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj
Outdated
Show resolved
Hide resolved
...bJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj
Outdated
Show resolved
Hide resolved
...bJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj
Outdated
Show resolved
Hide resolved
...bJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj
Outdated
Show resolved
Hide resolved
Y-Sindo
force-pushed
the
signalrversionconflict
branch
from
076fb0d to
3c79e36
Compare
* Removed and relocated `Microsoft.Azure.Functions.Extensions` package references in various project files. * Modify `AddDefaultAuth` method in `SignalRFunctionsHostBuilderExtensions.cs` to use `IServiceCollection` instead of `IFunctionsHostBuilder` to remove the dependency for legacy pacakge `Microsoft.Azure.Functions.Extensions`.
Y-Sindo
force-pushed
the
signalrversionconflict
branch
from
2d397a2 to
e5755b9
Compare
|
The pipeline failed due to issue #48456 |
|
Confirmed failures are unrelated to these changes. Merging. |
|
/check-enforcer override |
jsquire
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddDefaultAuthmethod inSignalRFunctionsHostBuilderExtensions.csto useIServiceCollectioninstead ofIFunctionsHostBuilderto remove the dependency for legacy pacakgeMicrosoft.Azure.Functions.Extensions.Microsoft.Azure.Functions.Extensionspackage references in various project files.