Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Newtonsoft] Publish new version of Batch dataplane for preview branch #4978

Merged
merged 5 commits into from
Nov 2, 2018
Merged

[Newtonsoft] Publish new version of Batch dataplane for preview branch #4978

merged 5 commits into from
Nov 2, 2018

Conversation

maddieclayton
Copy link
Contributor

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@maddieclayton
Copy link
Contributor Author

https://azuresdkci.westus2.cloudapp.azure.com/view/TEST-NetSdkJobs/job/MaddiePS-Sign/81/

@maddieclayton
Copy link
Contributor Author

@matthchr This is a rerelease for Batch dataplane for the PowerShell Batch preview module (with Newtonsoft Json 10). Can you take a look and let me know if you want me to make any changes?

matthchr
matthchr requested changes Nov 1, 2018
View reviewed changes
src/SDKs/Batch/DataPlane/Azure.Batch/Azure.Batch.csproj Outdated
@@ -28,7 +28,7 @@
<PropertyGroup>
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<PackageReleaseNotes>For detailed release notes, see: https://aka.ms/batch-net-dataplane-changelog</PackageReleaseNotes>
<PackageReleaseNotes>For detailed release notes, see: https://aka.ms/batch-net-dataplane-changelog. Taking dependency on 10.0.3 version of Newtonsoft nuget package.</PackageReleaseNotes>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't update this here -- update it in the actual changelog at src\SDKs\Batch\DataPlane\changelog.md

matthchr
matthchr reviewed Nov 2, 2018
View reviewed changes
src/SDKs/Batch/DataPlane/changelog.md Outdated
@@ -1,5 +1,8 @@
# Microsoft.Azure.Batch release notes

## Changes in 9.0.1
Taking dependency on 10.0.3 version of Newtonsoft nuget package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be: "- Updating Newtonsoft.Json to 1.0.3" or something like that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the dash prefix (formatted as list)

matthchr
matthchr requested changes Nov 2, 2018
View reviewed changes
src/SDKs/Batch/DataPlane/Azure.Batch/Azure.Batch.csproj Outdated
@@ -28,7 +28,7 @@
<PropertyGroup>
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<PackageReleaseNotes>For detailed release notes, see: https://aka.ms/batch-net-dataplane-changelog</PackageReleaseNotes>
<PackageReleaseNotes>For detailed release notes, see: https://aka.ms/batch-net-dataplane-changelog.</PackageReleaseNotes>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Remove the dot? (it'd be easy to copy that into the URL since nuget doesn't do links currently)

@matthchr
Copy link
Member

matthchr commented Nov 2, 2018

@maddieclayton - This looks good to me. Are you going to publish a new version or did you want me to do it?

@maddieclayton
Copy link
Contributor Author

@matthchr I can take care of publishing as soon as the PR is merged. Thanks for the review!

@maddieclayton maddieclayton merged commit 91af88d into Azure:psSdkJson6 Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthchr matthchr matthchr approved these changes

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees

@matthchr matthchr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maddieclayton @matthchr @shahabhijeet