Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShortTermRetentionManagadInstance #4982

Merged
merged 1 commit into from
Nov 7, 2018
Merged

ShortTermRetentionManagadInstance #4982

merged 1 commit into from
Nov 7, 2018

Conversation

v-djnisi
Copy link
Contributor

Description

Azure-Rest-API-Specs pull request: Azure/azure-rest-api-specs#3979

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@v-djnisi
Copy link
Contributor Author

Squashed commits from #4934

@v-djnisi v-djnisi mentioned this pull request Oct 31, 2018
Closed
9 tasks
dsgouda
dsgouda approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a .txt file generated/modified when code is generated, please commit this file too

dsgouda
dsgouda suggested changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some changes

@v-djnisi v-djnisi closed this Oct 31, 2018
@v-djnisi v-djnisi force-pushed the ManagedShortTermRetention branch from 75018cd to a50c4ab Compare October 31, 2018 18:36
@v-djnisi v-djnisi reopened this Oct 31, 2018
@v-djnisi
Copy link
Contributor Author

I regenerated files and pushed them. I used synced azure-rest-api branch before regenerating, and it generated some files that are not connected to my changes. Is that a problem?

@dsgouda
Copy link
Contributor

dsgouda commented Oct 31, 2018

These files are expected

@dsgouda
Copy link
Contributor

dsgouda commented Oct 31, 2018

@v-djnisi I have approved the PR but this cannot be merged until the PR for REST spec is merged.

jaredmoo
jaredmoo approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good overall, just need to update csproj & AssemblyInfo

@v-djnisi v-djnisi force-pushed the ManagedShortTermRetention branch from da44945 to 03e7b32 Compare November 5, 2018 11:21
@v-djnisi v-djnisi closed this Nov 5, 2018
@v-djnisi v-djnisi force-pushed the ManagedShortTermRetention branch from 03e7b32 to 91af88d Compare November 5, 2018 11:37
@v-djnisi v-djnisi reopened this Nov 5, 2018
@v-djnisi v-djnisi force-pushed the ManagedShortTermRetention branch from 9411339 to 301ee95 Compare November 5, 2018 15:00
@jaredmoo
Copy link
Contributor

jaredmoo commented Nov 5, 2018

@dsgouda please take a look at Travis build failure, it's not in our area

@v-djnisi
Copy link
Contributor Author

v-djnisi commented Nov 7, 2018 •
edited
Loading

@jaredmoo @dsgouda I don't see any failures.
image

One more thing, is there a reason why we are not merging this API? It seems to me that this PR is waiting on rest-api-for-specs, and rest-api-for-specs is waiting on this PR. Is there anything I can do besides pinging? We need to finish powershell by the end of the month.

@dsgouda
Copy link
Contributor

dsgouda commented Nov 7, 2018

@v-djnisi @jaredmoo it looks like the REST spec API PR is still not merged. We won't be able to merge this PR until the REST spec gets merged

@v-djnisi
Copy link
Contributor Author

v-djnisi commented Nov 7, 2018

@dsgouda azure-rest-api-specs just got approved and merged.

dsgouda
dsgouda approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 65d20d5 into Azure:psSdkJson6 Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-djnisi @dsgouda @jaredmoo