Don't execute tracing on message if no tracing loaded

Azure · Sep 19, 2019 · dedae18 · dedae18
1 parent 68fe228
commit dedae18
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/sdk/eventhub/azure-eventhubs/azure/eventhub/aio/producer_async.py b/sdk/eventhub/azure-eventhubs/azure/eventhub/aio/producer_async.py
@@ -223,12 +223,13 @@ async def send(
             child.kind = SpanKind.CLIENT  # Should be PRODUCER
 
         def trace_message(message):
-            message_span = child.span(name="Azure.EventHubs.message")
-            message_span.start()
-            app_prop = dict(message.application_properties)
-            app_prop.setdefault(b"Diagnostic-Id", message_span.get_trace_parent().encode('ascii'))
-            message.application_properties = app_prop
-            message_span.finish()
+            if span_impl_type is not None:
+                message_span = child.span(name="Azure.EventHubs.message")
+                message_span.start()
+                app_prop = dict(message.application_properties)
+                app_prop.setdefault(b"Diagnostic-Id", message_span.get_trace_parent().encode('ascii'))
+                message.application_properties = app_prop
+                message_span.finish()
 
         self._check_closed()
         if isinstance(event_data, EventData):

diff --git a/sdk/eventhub/azure-eventhubs/azure/eventhub/producer.py b/sdk/eventhub/azure-eventhubs/azure/eventhub/producer.py
@@ -228,12 +228,13 @@ def send(self, event_data, partition_key=None, timeout=None):
             child.kind = SpanKind.CLIENT  # Should be PRODUCER
 
         def trace_message(message):
-            message_span = child.span(name="Azure.EventHubs.message")
-            message_span.start()
-            app_prop = dict(message.application_properties)
-            app_prop.setdefault(b"Diagnostic-Id", message_span.get_trace_parent().encode('ascii'))
-            message.application_properties = app_prop
-            message_span.finish()
+            if span_impl_type is not None:
+                message_span = child.span(name="Azure.EventHubs.message")
+                message_span.start()
+                app_prop = dict(message.application_properties)
+                app_prop.setdefault(b"Diagnostic-Id", message_span.get_trace_parent().encode('ascii'))
+                message.application_properties = app_prop
+                message_span.finish()
 
         self._check_closed()
         if isinstance(event_data, EventData):