Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckPrivateLinkServiceVisibility api in network has changed #11627

Closed
00Kai0 opened this issue May 26, 2020 · 8 comments
Closed

CheckPrivateLinkServiceVisibility api in network has changed #11627

00Kai0 opened this issue May 26, 2020 · 8 comments
Labels
issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. Network - Private Link question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@00Kai0
Copy link
Contributor

00Kai0 commented May 26, 2020 

request:
    body: '{"privateLinkServiceAlias": "mypls.00000000-0000-0000-0000-000000000000.azure.privatelinkservice"}'
    headers:
      Accept:
      - application/json
      Accept-Encoding:
      - gzip, deflate
      Connection:
      - keep-alive
      Content-Length:
      - '98'
      Content-Type:
      - application/json
      User-Agent:
      - azsdk-python-azure-mgmt-network/11.0.0 Python/3.6.9 (Linux-4.9.184-linuxkit-x86_64-with-Ubuntu-18.04-bionic)
    method: POST
    uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test_cli_mgmt_network_endpoint_test_network89b511ec/providers/Microsoft.Network/locations/eastus/checkPrivateLinkServiceVisibility?api-version=2020-04-01
  response:
    body:
      string: 'null'
    headers:
      azure-asyncoperation:
      - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operations/93d10632-9dba-4dab-9763-ec8705fbd40e?api-version=2020-04-01
      cache-control:
      - no-cache
      content-length:
      - '4'
      content-type:
      - application/json; charset=utf-8
      date:
      - Fri, 22 May 2020 09:37:48 GMT
      expires:
      - '-1'
      location:
      - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operationResults/93d10632-9dba-4dab-9763-ec8705fbd40e?api-version=2020-04-01
      pragma:
      - no-cache
      server:
      - Microsoft-HTTPAPI/2.0
      - Microsoft-HTTPAPI/2.0
      strict-transport-security:
      - max-age=31536000; includeSubDomains
      x-content-type-options:
      - nosniff
      x-ms-arm-service-request-id:
      - 746f965a-4c48-49ac-8842-55546ee5664e
      x-ms-ratelimit-remaining-subscription-writes:
      - '1199'
    status:
      code: 202
      message: Accepted

This checkPrivateLinkServiceVisibility api returned an unexcepted code 202. I think it has been change to a LRO method, but hasn't been updated in swagger.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 26, 2020
@00Kai0
Copy link
Contributor Author

00Kai0 commented May 26, 2020

#11601

@lmazuel
Copy link
Member

lmazuel commented May 26, 2020

That should be a critical bug fix in Swagger, not something you workaround here, just my two cents. CC @RodgeFu

@RodgeFu
Copy link
Member

RodgeFu commented May 26, 2020

+1, let's wait for network team to confirm the behavior change and work with them to fix the swagger. thanks.

@lmazuel lmazuel added Mgmt This issue is related to a management-plane library. Network Service Attention Workflow: This issue is responsible by Azure service team. labels Nov 9, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 9, 2020
@ghost
Copy link

ghost commented Nov 9, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aznetsuppgithub.

Issue meta data
Issue content: ``` request: body: '{"privateLinkServiceAlias": "mypls.00000000-0000-0000-0000-000000000000.azure.privatelinkservice"}' headers: Accept: - application/json Accept-Encoding: - gzip, deflate Connection: - keep-alive Content-Length: - '98' Content-Type: - application/json User-Agent: - azsdk-python-azure-mgmt-network/11.0.0 Python/3.6.9 (Linux-4.9.184-linuxkit-x86_64-with-Ubuntu-18.04-bionic) method: POST uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test_cli_mgmt_network_endpoint_test_network89b511ec/providers/Microsoft.Network/locations/eastus/checkPrivateLinkServiceVisibility?api-version=2020-04-01 response: body: string: 'null' headers: azure-asyncoperation: - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operations/93d10632-9dba-4dab-9763-ec8705fbd40e?api-version=2020-04-01 cache-control: - no-cache content-length: - '4' content-type: - application/json; charset=utf-8 date: - Fri, 22 May 2020 09:37:48 GMT expires: - '-1' location: - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operationResults/93d10632-9dba-4dab-9763-ec8705fbd40e?api-version=2020-04-01 pragma: - no-cache server: - Microsoft-HTTPAPI/2.0 - Microsoft-HTTPAPI/2.0 strict-transport-security: - max-age=31536000; includeSubDomains x-content-type-options: - nosniff x-ms-arm-service-request-id: - 746f965a-4c48-49ac-8842-55546ee5664e x-ms-ratelimit-remaining-subscription-writes: - '1199' status: code: 202 message: Accepted ``` This [checkPrivateLinkServiceVisibility api](https://docs.microsoft.com/en-us/rest/api/virtualnetwork/privatelinkservices/checkprivatelinkservicevisibility) returned an unexcepted code 202. I think it has been change to a LRO method, but hasn't been updated in swagger.
Issue author: 00Kai0
Assignees: -
Milestone: -

@lmazuel lmazuel added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 9, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 9, 2020
@ghost
Copy link

ghost commented Nov 9, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @privlinksuppgithub.

Issue meta data
Issue content: ``` request: body: '{"privateLinkServiceAlias": "mypls.00000000-0000-0000-0000-000000000000.azure.privatelinkservice"}' headers: Accept: - application/json Accept-Encoding: - gzip, deflate Connection: - keep-alive Content-Length: - '98' Content-Type: - application/json User-Agent: - azsdk-python-azure-mgmt-network/11.0.0 Python/3.6.9 (Linux-4.9.184-linuxkit-x86_64-with-Ubuntu-18.04-bionic) method: POST uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test_cli_mgmt_network_endpoint_test_network89b511ec/providers/Microsoft.Network/locations/eastus/checkPrivateLinkServiceVisibility?api-version=2020-04-01 response: body: string: 'null' headers: azure-asyncoperation: - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operations/93d10632-9dba-4dab-9763-ec8705fbd40e?api-version=2020-04-01 cache-control: - no-cache content-length: - '4' content-type: - application/json; charset=utf-8 date: - Fri, 22 May 2020 09:37:48 GMT expires: - '-1' location: - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operationResults/93d10632-9dba-4dab-9763-ec8705fbd40e?api-version=2020-04-01 pragma: - no-cache server: - Microsoft-HTTPAPI/2.0 - Microsoft-HTTPAPI/2.0 strict-transport-security: - max-age=31536000; includeSubDomains x-content-type-options: - nosniff x-ms-arm-service-request-id: - 746f965a-4c48-49ac-8842-55546ee5664e x-ms-ratelimit-remaining-subscription-writes: - '1199' status: code: 202 message: Accepted ``` This [checkPrivateLinkServiceVisibility api](https://docs.microsoft.com/en-us/rest/api/virtualnetwork/privatelinkservices/checkprivatelinkservicevisibility) returned an unexcepted code 202. I think it has been change to a LRO method, but hasn't been updated in swagger.
Issue author: 00Kai0
Assignees: -
Milestone: -

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Nov 25, 2020
CodeGen from PR 11627 in Azure/azure-rest-api-specs
1e24bbd 
[Hub Generated] Review request for Microsoft.Logic to add version stable/2019-05-01 (Azure#11627)

* Adding integration service environment encryption configuration details to Logic spec

* Correcting json format errors

* Correcting json formats

* Updating examples

* Fixing encryption key properties definition

Co-authored-by: Rama Krishna Rayudu <[email protected]>
@xiangyan99
Copy link
Member

@00Kai0 could you check if this is still reproable?

@RAY-316 RAY-316 added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Dec 15, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Hi @00Kai0. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost
Copy link

ghost commented Dec 22, 2021

Hi @00Kai0, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Dec 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. Network - Private Link question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lmazuel @RodgeFu @xiangyan99 @00Kai0 @timMSFT @RAY-316