Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys][ServiceBus/Tables] Remove workaround in preparers.py after fixing cosmos non-recording tests. #14217

Closed
KieranBrantnerMagee opened this issue Oct 2, 2020 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative. Service Bus Tables
Milestone

Comments

@KieranBrantnerMagee
Copy link
Member

For the hotfix here

This fix should be deprecated and the underlying problem addressed. It was initially constructed to handle tests that were marked live but did not have a recording/did not generate HTTP traffic, but if used in cached mode, this would cause problems with how the in_recording variable is set. (it sets a random name which is then preserved in the cache)

In conversation with @lmazuel there is a more appropriate angle to fix this: Tests that do not generate recordings simply should not be AzureTestCases. Either the work to set up the resource should be in the test, not a preparer, (if you actually wanted a live resource) or it should be mocked and unit-testable.

One of these fixes should be applied to the cosmos tests in question, and the workaround clause should be yanked.

@KieranBrantnerMagee KieranBrantnerMagee added Service Bus EngSys This issue is impacting the engineering system. Tables blocking-release Blocks release labels Oct 2, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] November milestone Oct 2, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Oct 2, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @southpolesteve, @zfoster

@KieranBrantnerMagee KieranBrantnerMagee added the MQ This issue is part of a "milestone of quality" initiative. label Oct 7, 2020
@ramya-rao-a ramya-rao-a removed the blocking-release Blocks release label Oct 22, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] November, MQ-2020 Oct 22, 2020
@kurtzeborn kurtzeborn added the Client This issue points to a problem in the data-plane of the library. label Dec 3, 2020
@lmazuel lmazuel modified the milestones: MQ-2020, [2021] February Jan 9, 2021
@yunhaoling yunhaoling assigned lmazuel and unassigned yunhaoling Jan 13, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue May 13, 2021
fixed network resources, updates from previous version (Azure#14217)
msyyc added a commit that referenced this issue May 17, 2021
* CodeGen from PR 14217 in Azure/azure-rest-api-specs
fixed network resources, updates from previous version (#14217)

* version,CHANGELOG

* test

* test

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: msyyc <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative. Service Bus Tables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants