Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBusAdministrationClient now uses _parse_conn_str from base_han… #14228

Merged
merged 4 commits into from
Oct 9, 2020
Merged

ServiceBusAdministrationClient now uses _parse_conn_str from base_han… #14228

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0903ec0
ServiceBusAdministrationClient now uses _parse_conn_str from base_han…
bradleydamato Oct 2, 2020
1e594dc
Remove parse_conn_str() from common.utils and replace parse_conn_str(…
Oct 8, 2020
307b86b
add underscore to base_handler import statement
bradleydamato Oct 8, 2020
4e3c604
Fixing pylint: removed unused module time from _common/utils.py
Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sdk/servicebus/azure-servicebus/azure/servicebus/management/_management_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
from ._xml_workaround_policy import ServiceBusXMLWorkaroundPolicy

from .._common.constants import JWT_TOKEN_SCOPE
from .._common.utils import parse_conn_str
from .._base_handler import ServiceBusSharedKeyCredential, ServiceBusSASTokenCredential
from .._base_handler import _parse_conn_str, ServiceBusSharedKeyCredential, ServiceBusSASTokenCredential
from ._shared_key_policy import ServiceBusSharedKeyCredentialPolicy
from ._generated._configuration import ServiceBusManagementClientConfiguration
from ._generated._service_bus_management_client import ServiceBusManagementClient as ServiceBusManagementClientImpl
Expand Down Expand Up @@ -130,7 +129,7 @@ def from_connection_string(cls, conn_str, **kwargs):
:param str conn_str: The connection string of the Service Bus Namespace.
:rtype: ~azure.servicebus.management.ServiceBusAdministrationClient
"""
endpoint, shared_access_key_name, shared_access_key, _, token, token_expiry = parse_conn_str(conn_str)
endpoint, shared_access_key_name, shared_access_key, _, token, token_expiry = _parse_conn_str(conn_str)
if token and token_expiry:
credential = ServiceBusSASTokenCredential(token, token_expiry)
elif shared_access_key_name and shared_access_key:
Expand Down