Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic PR of restapi_auto_lmazuel_automationpy into master #1801

Conversation

AutorestCI
Copy link
Contributor

@vrdmr
Copy link
Member

vrdmr commented Feb 2, 2018

Hi @lmazuel, The PR failed searching for the setup.py, when it tried to install pip install -e azure-mgmt-automation. Could you please have a look at this?

@lmazuel
Copy link
Member

lmazuel commented Feb 2, 2018

The setup.py is there, could you pass the actual error message you get?

@vrdmr
Copy link
Member

vrdmr commented Feb 2, 2018

In all the builds, I see the following:

Py2.7

Executing: pip install -e azure-mgmt-automation
The command "python scripts/dev_setup.py" failed and exited with 1 during .

Py3.6

Executing: pip install -e azure-mgmt-redis
Executing: pip install -e azure-mgmt-automation
The command "python scripts/dev_setup.py" failed and exited with 1 during .
Your build has been stopped.

@lmazuel
Copy link
Member

lmazuel commented Feb 2, 2018

Should be better now, the package didn't have a version, which is require for pip install.

@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #1801 into master will decrease coverage by 1.2%.
The diff coverage is 29.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1801      +/-   ##
==========================================
- Coverage    52.8%   51.59%   -1.21%     
==========================================
  Files        4577     4810     +233     
  Lines      112520   124258   +11738     
==========================================
+ Hits        59412    64117    +4705     
- Misses      53108    60141    +7033
Impacted Files Coverage Δ
...gmt/automation/operations/connection_operations.py 10.18% <10.18%> (ø)
...e/mgmt/automation/operations/runbook_operations.py 10.34% <10.34%> (ø)
...mt/automation/operations/certificate_operations.py 10.47% <10.47%> (ø)
.../mgmt/automation/operations/variable_operations.py 10.57% <10.57%> (ø)
...re/mgmt/automation/operations/module_operations.py 10.57% <10.57%> (ø)
...omation/operations/dsc_configuration_operations.py 10.67% <10.67%> (ø)
.../mgmt/automation/operations/schedule_operations.py 10.78% <10.78%> (ø)
azure-mgmt-automation/azure/mgmt/__init__.py 100% <100%> (ø)
azure-mgmt-automation/azure/__init__.py 100% <100%> (ø)
...ation/azure/mgmt/automation/operations/__init__.py 100% <100%> (ø)
... and 860 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b64f4...772d465. Read the comment docs.

@vrdmr
Copy link
Member

vrdmr commented Feb 6, 2018

Hi @lmazuel, Can you please merge this PR? Thanks.

@lmazuel
Copy link
Member

lmazuel commented Feb 7, 2018

@vrdmr You mean merge and release right? Just to be sure :)
Meaning you tested it and it works as expected?

@lmazuel lmazuel changed the base branch from master to restapi_auto_automation/resource-manager February 12, 2018 17:36
@lmazuel lmazuel merged commit d99b551 into restapi_auto_automation/resource-manager Feb 12, 2018
@lmazuel lmazuel deleted the restapi_auto_lmazuel_automationpy branch February 12, 2018 17:36
AutorestCI added a commit that referenced this pull request Feb 28, 2018
* Generated from c5f717c032612695b124bb479253012db871267e

Python conf for Automation

* Packaging for azure-mgmt-automation

* Update version.py
AutorestCI added a commit that referenced this pull request Mar 7, 2018
* Generated from c5f717c032612695b124bb479253012db871267e

Python conf for Automation

* Packaging for azure-mgmt-automation

* Update version.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants