Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit dependency on successful completion of verify-links #18277

Merged
merged 4 commits into from
May 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions eng/pipelines/templates/steps/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,19 @@ steps:
# target is based on data available per-package the --always-succeed should
# be removed so this script can help enforce correct practices
# (https://github.com/Azure/azure-sdk-for-python/issues/8697)


- pwsh: |
pip install -r eng/ci_tools.txt $(if($IsWindows) {"--user" })
displayName: 'Install Necessary Dependencies'
condition: succeededOrFailed()

- script: |
cd eng/versioning
pip install -r requirements.txt
python find_invalid_versions.py --always-succeed --service=${{parameters.ServiceDirectory}}
displayName: Find Invalid Versions
condition: succeededOrFailed()

- pwsh: |
Get-ChildItem $(Build.SourcesDirectory) -Filter "*.py" |
Expand Down
4 changes: 4 additions & 0 deletions eng/pipelines/templates/steps/analyze_dependency.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,25 @@
steps:
- task: UsePythonVersion@0
displayName: 'Use Python $(PythonVersion)'
condition: succeededOrFailed()
inputs:
versionSpec: '$(PythonVersion)'

- pwsh: |
pip install -r eng/ci_tools.txt $(if($IsWindows) {"--user" })
ward scan -d $(Build.SourcesDirectory) -c $(Build.SourcesDirectory)/eng/.docsettings.yml
displayName: 'Verify Readmes'
condition: succeededOrFailed()

- pwsh: |
mkdir "$(Build.ArtifactStagingDirectory)/reports"
Copy-Item -Path "$(Build.SourcesDirectory)/eng/common/InterdependencyGraph.html" -Destination "$(Build.ArtifactStagingDirectory)/reports/InterdependencyGraph.html"
displayName: 'Populate Reports Staging Folder'
condition: succeededOrFailed()

- task: PythonScript@0
displayName: 'Analyze dependencies'
condition: succeededOrFailed()
inputs:
scriptPath: 'scripts/analyze_deps.py'
arguments: '--verbose --out "$(Build.ArtifactStagingDirectory)/reports/dependencies.html" --dump "$(Build.ArtifactStagingDirectory)/reports/data.js"'