Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR containerinstance/resource-manager] Fixing Error in Naming Convention for Rows and Cols in Terminal Size #2169

Merged

Conversation

AutorestCI
Copy link
Contributor

Fixing error in naming convention for rows and cols
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Mar 14, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-containerinstance

You can install the package azure-mgmt-containerinstance of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_2651#egg=azure-mgmt-containerinstance&subdirectory=azure-mgmt-containerinstance"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_2651#egg=azure-mgmt-containerinstance&subdirectory=azure-mgmt-containerinstance"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_2651
  • pip install -e ./azure-mgmt-containerinstance

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_2651
  • pip wheel --no-deps ./azure-mgmt-containerinstance

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

Codecov Report

Merging #2169 into restapi_auto_containerinstance/resource-manager will increase coverage by 1.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                                 Coverage Diff                                 @@
##           restapi_auto_containerinstance/resource-manager    #2169      +/-   ##
===================================================================================
+ Coverage                                            52.05%    53.1%   +1.04%     
===================================================================================
  Files                                                 5149     4778     -371     
  Lines                                               132333   119598   -12735     
===================================================================================
- Hits                                                 68889    63514    -5375     
+ Misses                                               63444    56084    -7360
Impacted Files Coverage Δ
...nce/models/container_exec_request_terminal_size.py 57.14% <33.33%> (ø) ⬆️
...ork/azure/mgmt/network/v2017_10_01/models/probe.py 33.33% <0%> (-8.78%) ⬇️
...etwork/v2017_11_01/models/packet_capture_result.py 31.25% <0%> (-8.75%) ⬇️
...etwork/v2017_10_01/models/packet_capture_result.py 31.25% <0%> (-8.75%) ⬇️
...17_10_01/models/verification_ip_flow_parameters.py 35.71% <0%> (-8.74%) ⬇️
...re/mgmt/network/v2017_10_01/models/ipsec_policy.py 35.71% <0%> (-8.74%) ⬇️
...re/mgmt/network/v2017_11_01/models/ipsec_policy.py 35.71% <0%> (-8.74%) ⬇️
...17_11_01/models/verification_ip_flow_parameters.py 35.71% <0%> (-8.74%) ⬇️
...rk/v2017_11_01/models/connection_monitor_result.py 26.31% <0%> (-8.47%) ⬇️
.../network/v2017_10_01/models/load_balancing_rule.py 26.31% <0%> (-8.47%) ⬇️
... and 557 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac83d7...262fb39. Read the comment docs.

@AutorestCI AutorestCI merged commit 6354114 into restapi_auto_containerinstance/resource-manager Mar 15, 2018
lmazuel pushed a commit that referenced this pull request Mar 20, 2018
* [AutoPR containerinstance/resource-manager] Adding Container Exec Spec (#2114)

* Generated from a60b503fd362577f4fab95a5e2518b553ec284e9

fixing small syntax error

* Generated from 1ec1e3fd40e63a08d3262affca1203988f7407ef

Updating correct examples for async operation

* Generated from 24d60116617096cd26598e974ac7e1fa00ec8169

fixing ARM header field

* Generated from 9fecbb9feb0b8ea3cbba6a02e84973b2bdf11378

remvoing extra async operations

* Generated from 338812373b418f43cc56c9cf152a99475fbe12e1

Update Python version

* Update tests and ChangeLog

* Generated from 2f0dc17f7d69b23e41058c6aa7eef3946337ffd6 (#2169)

Fixing error in naming convention for rows and cols

* Adding sanity tests for start container exec

* updating the recording file

* Final release date
@lmazuel lmazuel deleted the restapi_auto_2651 branch April 27, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants