-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLU] support for AAD + docs #24960
Merged
Merged
[CLU] support for AAD + docs #24960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check APIView has identified API level changes in this PR and created following API reviews. |
heaths
reviewed
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly LGTM, but a couple of pythonisms you'd be better to get other (snake) eyes on.
sdk/cognitivelanguage/azure-ai-language-conversations/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/cognitivelanguage/azure-ai-language-conversations/README.md
Outdated
Show resolved
Hide resolved
sdk/cognitivelanguage/azure-ai-language-conversations/README.md
Outdated
Show resolved
Hide resolved
...cognitivelanguage/azure-ai-language-conversations/azure/ai/language/conversations/_client.py
Show resolved
Hide resolved
...cognitivelanguage/azure-ai-language-conversations/azure/ai/language/conversations/_client.py
Show resolved
Hide resolved
...nguage/azure-ai-language-conversations/azure/ai/language/conversations/aio/_configuration.py
Show resolved
Hide resolved
heaths
reviewed
Jun 23, 2022
iscai-msft
approved these changes
Jun 24, 2022
heaths
approved these changes
Jun 24, 2022
sdk/cognitivelanguage/azure-ai-language-conversations/README.md
Outdated
Show resolved
Hide resolved
sdk/cognitivelanguage/azure-ai-language-conversations/README.md
Outdated
Show resolved
Hide resolved
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 27, 2022
…into merge_patch * 'main' of https://github.com/Azure/azure-sdk-for-python: (155 commits) {machine learning} || Fix a bug in the code (Azure#24922) [CLU] support for AAD + docs (Azure#24960) Update dpg version (Azure#24986) [Botservice]fix model (Azure#24971) [perf] Add pipeline template and storage pipelines (Azure#24894) [Storage] Remove client-side encryption code from shared (Azure#24931) [EventHubs&ServiceBus] update docker images to internal (Azure#24966) Sync eng/common directory with azure-sdk-tools for PR 3481 (Azure#24964) [Dpg] update to use global autorest version (Azure#24970) [CLU] release updates + fix tests (Azure#24963) [Test Proxy] Add method to reset setting customizations (Azure#24952) [Storage] Add proxy-supporting test classes (Azure#24937) [Confidential Ledger] Enable live testing (Azure#24912) fix type of _SansIOHTTPPolicyRunner (Azure#24932) Adding SIP routing functionality to PhoneNumbers SDK (Azure#22805) [DPG] update quick-start-tool (Azure#24942) [formrecognizer] Enable copy model tests (Azure#24917) [CLU] remove maxpagesize (Azure#24949) Use westus3 for translation live tests (Azure#24947) [Storage] Make lease duration tests less flakey (Azure#24930) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.