Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default resource detector env var and add auto-instrumentation resource detector #33340

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

jeremydvoss
Copy link
Member

Description

Follow up to #33305 and fix for #33295, and #33253. Changed resource detector behavior to only default the env var. This will allow customers to customize resource detectors and disable any that may cause issues.

Also, adding the app service detector to auto-insturmentation

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@jeremydvoss jeremydvoss requested a review from lzchen as a code owner November 29, 2023 22:14
@github-actions github-actions bot added the Monitor - Distro Monitor OpenTelemetry Distro label Nov 29, 2023
@jeremydvoss jeremydvoss force-pushed the attach-resource-detector branch from 649ee34 to f88ff1f Compare November 29, 2023 22:32
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jeremydvoss jeremydvoss enabled auto-merge (squash) November 29, 2023 23:25
@jeremydvoss jeremydvoss merged commit e96d71b into Azure:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Distro Monitor OpenTelemetry Distro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants