Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Proxy] Sanitize OAuth requests/responses throughout SDK by default #34866

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Mar 20, 2024

Description

OAuth interactions are a major potential source of test principal secret leakage if client data isn't correctly sanitized elsewhere. Since these interactions aren't necessary for any tests that I'm aware of, and sanitizing them won't break any existing functionality, this updates the test proxy's startup code to automatically register the OAuth response sanitizer, thereby opting everyone in to sanitizing them.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added the test-proxy Anything relating to test-proxy requests or issues. label Mar 20, 2024
@mccoyp
Copy link
Member Author

mccoyp commented Mar 20, 2024

/azp run python - storage - ci

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mccoyp mccoyp marked this pull request as ready for review March 21, 2024 18:03
@mccoyp mccoyp requested a review from scbedd as a code owner March 21, 2024 18:03
@mccoyp mccoyp merged commit 484c233 into Azure:main Mar 21, 2024
21 checks passed
@mccoyp mccoyp deleted the oauth-sanitize branch March 21, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-proxy Anything relating to test-proxy requests or issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants