Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource param #34900

Merged
merged 14 commits into from
Apr 5, 2024
Merged

Resource param #34900

merged 14 commits into from
Apr 5, 2024

Conversation

jeremydvoss
Copy link
Member

Description

Enable resource pass in

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Monitor - Distro Monitor OpenTelemetry Distro label Mar 23, 2024
@jeremydvoss jeremydvoss marked this pull request as ready for review March 23, 2024 01:03
@jeremydvoss jeremydvoss requested a review from lzchen as a code owner March 23, 2024 01:03
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-monitor-opentelemetry

lzchen
lzchen previously requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test case.

@jeremydvoss jeremydvoss dismissed lzchen’s stale review April 4, 2024 20:51

Already done before this PR. Resource configuration already existed. It just wasn't configurable through a param -- only env vars and detectors.

@jeremydvoss jeremydvoss mentioned this pull request Apr 4, 2024
Merged
6 tasks
@jeremydvoss
Copy link
Member Author

Waiting for #35075

@jeremydvoss jeremydvoss enabled auto-merge (squash) April 4, 2024 22:51
@jeremydvoss jeremydvoss merged commit d51635b into Azure:main Apr 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@annatisch annatisch annatisch approved these changes

Assignees
No one assigned
Labels
Monitor - Distro Monitor OpenTelemetry Distro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremydvoss @azure-sdk @annatisch @lzchen