Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: fixed bug so tracing won't wrap None functions #7451

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Tracing: fixed bug so tracing won't wrap None functions #7451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b564a9
fixed bug so tracing won't wrap None functions
iscai-msft Sep 26, 2019
c5cdb47
added opencensus threading package to dev requirements
iscai-msft Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/core/azure-core/azure/core/tracing/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def with_current_context(func):
:return: The target the pass in instead of the function
"""
span_impl_type = settings.tracing_implementation() # type: Type[AbstractSpan]
if span_impl_type is not None:
if span_impl_type is None:
return func

return span_impl_type.with_current_context(func)
1 change: 1 addition & 0 deletions sdk/core/azure-core/dev_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ aiodns>=2.0; python_version >= '3.5'
typing_extensions>=3.7.2
opencensus>=0.6.0
opencensus-ext-azure>=0.3.1
opencensus-ext-threading
mock