-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not convert dates #1986
Do not convert dates #1986
Conversation
@JeffreyRichter can you have a look as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching from 1123 to 7231 now is fine. But of course, we can't chase RFC numbers as the years go on.
Agreed. And given TypeSpec documents "rfc7231" as a supported |
Technically, we weren't because we weren't capturing the return of `to_offset()`, but this cleans up the code and adds some tests that caused us to miss this. Relates to Azure#1982
Actually resolves Azure#1982
Technically, we weren't because we weren't capturing the return of
to_offset()
, but this cleans up the code and adds some tests that caused us to miss this.Resolves #1982
This also renames RFC 1123 functions to 7231, which obsolesces 1123 effectively; though, is itself obsolesced by 9110. We do refer to 7231 in both TypeSpec and REST API Guidelines already, though.